feat(rofl/build): Set x86_64-unknown-linux-gnu target for Localnet build #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-cli canceled.
|
kostko
approved these changes
Sep 12, 2024
matevz
force-pushed
the
matevz/feature/rofl-build-debug-x86-flag
branch
from
8ff6982 to
21d81ca
Compare
matevz
changed the title
kostko
reviewed
Sep 12, 2024
The current behavior silently falls back to production builds when your Localnet is not accessible. If --mode is auto, then it should fail, when the connection cannot be established.
In order to be compatible with alpine linux builds we use in our containers, the target needs to be built for musl instead of gnu.
matevz
force-pushed
the
matevz/feature/rofl-build-debug-x86-flag
branch
from
c7dd62f to
0a4993c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On MacOS the default target must be set to x86_64 since this is the only platform we currently support.
Related oasisprotocol/sapphire-paratime#377